From f2b71fe1d3c2b7651d525a5b5bbe66fad602ea06 Mon Sep 17 00:00:00 2001
From: 啊鑫 <t2856754968@163.com>
Date: 星期二, 09 九月 2025 18:46:28 +0800
Subject: [PATCH] 代码清理
---
WebApi/Gs.JJGZ/MesDeToLineController.cs | 93 +++++++++++++++++++++++++++++-----------------
1 files changed, 58 insertions(+), 35 deletions(-)
diff --git a/WebApi/Gs.JJGZ/MesDeToLineController.cs b/WebApi/Gs.JJGZ/MesDeToLineController.cs
index 2ad1a5d..1b7b1cf 100644
--- a/WebApi/Gs.JJGZ/MesDeToLineController.cs
+++ b/WebApi/Gs.JJGZ/MesDeToLineController.cs
@@ -1,7 +1,4 @@
-锘縰sing System.Data;
-using System.Data.SqlClient;
-using System.Dynamic;
-using System.Text;
+锘縰sing System.Dynamic;
using Gs.Toolbox;
using Gs.Toolbox.ApiCore.Abstract.Mvc;
using Gs.Toolbox.ApiCore.Common.Mvc;
@@ -18,6 +15,7 @@
private readonly IHttpContextAccessor _http;
private readonly string _userCode, _userGuid, _orgFids;
+
public MesDeToLineController(IHttpContextAccessor httpContextAccessor)
{
_http = httpContextAccessor;
@@ -38,7 +36,7 @@
int everyPageSize = model.everyPageSize;
string sortName = model.sortName;
string keyWhere = model.keyWhere;
-
+
var _pglist = new PageList<dynamic>
{
total = 0,
@@ -49,19 +47,23 @@
try
{
// 鏋勫缓鍒嗛〉鏌ヨSQL
- string whereClause = string.IsNullOrEmpty(keyWhere) ? "" : keyWhere;
- string orderBy = string.IsNullOrEmpty(sortName) ? "CREATE_DATE DESC" : $"{sortName} ASC";
-
+ var whereClause = string.IsNullOrEmpty(keyWhere) ? "" : keyWhere;
+ var orderBy = string.IsNullOrEmpty(sortName)
+ ? "CREATE_DATE DESC"
+ : $"{sortName} ASC";
+
// 鏌ヨ鎬绘暟
- string countSql = $"SELECT COUNT(1) FROM Mes_DepartmentToLine a WHERE 1=1 {whereClause}";
+ var countSql =
+ $"SELECT COUNT(1) FROM Mes_DepartmentToLine a WHERE 1=1 {whereClause}";
var countResult = DbHelperSQL.GetSingle(countSql);
- int intTotal = countResult != null ? Convert.ToInt32(countResult) : 0;
-
+ var intTotal =
+ countResult != null ? Convert.ToInt32(countResult) : 0;
+
if (intTotal > 0)
{
// 鍒嗛〉鏌ヨ鏁版嵁
- int offset = (currentPage - 1) * everyPageSize;
- string dataSql = $@"
+ var offset = (currentPage - 1) * everyPageSize;
+ var dataSql = $@"
SELECT * FROM (
SELECT ROW_NUMBER() OVER (ORDER BY {orderBy}) AS RowNum, A.*, b.Name as OrgName
FROM Mes_DepartmentToLine A
@@ -70,9 +72,10 @@
WHERE 1=1 {whereClause}
) AS T
WHERE T.RowNum BETWEEN {offset + 1} AND {offset + everyPageSize}";
-
+
var dsMain = DbHelperSQL.Query(dataSql);
- if (dsMain != null && dsMain.Tables.Count > 0 && dsMain.Tables[0].Rows.Count > 0)
+ if (dsMain != null && dsMain.Tables.Count > 0 &&
+ dsMain.Tables[0].Rows.Count > 0)
{
var pages = intTotal % everyPageSize != 0
? intTotal / everyPageSize + 1
@@ -89,8 +92,9 @@
{
LogHelper.Debug(ToString(), ex.Message);
return ReturnDto<PageList<dynamic>>.QuickReturn(_pglist,
- ReturnCode.Exception, ex.Message);
+ ReturnCode.Exception, ex.Message);
}
+
return ReturnDto<PageList<dynamic>>.QuickReturn(_pglist,
ReturnCode.Success, "璇诲彇鎴愬姛");
}
@@ -105,12 +109,13 @@
{
string guid = model.guid.ToString();
dynamic m = new ExpandoObject();
- string mainTable = "Mes_DepartmentToLine";
+ var mainTable = "Mes_DepartmentToLine";
try
{
- string sqlMain = $"SELECT * FROM {mainTable} WHERE GUID='{guid}'";
+ var sqlMain = $"SELECT * FROM {mainTable} WHERE GUID='{guid}'";
var dsMain = DbHelperSQL.Query(sqlMain);
- if (dsMain != null && dsMain.Tables.Count > 0 && dsMain.Tables[0].Rows.Count > 0)
+ if (dsMain != null && dsMain.Tables.Count > 0 &&
+ dsMain.Tables[0].Rows.Count > 0)
{
var dr = dsMain.Tables[0].Rows[0];
m = dr.RowToDynamic();
@@ -120,8 +125,10 @@
{
LogHelper.Debug(ToString(), ex.Message);
}
+
if (m != null)
- return ReturnDto<dynamic>.QuickReturn(m, ReturnCode.Success, "璇诲彇鎴愬姛锛�");
+ return ReturnDto<dynamic>.QuickReturn(m, ReturnCode.Success,
+ "璇诲彇鎴愬姛锛�");
return ReturnDto<dynamic>.QuickReturn(m, ReturnCode.Default, "璇诲彇澶辫触锛�");
}
@@ -140,8 +147,9 @@
m.outMsg = "";
try
{
- string sql = $"UPDATE Mes_DepartmentToLine SET CHECK_STATUS='{_inFieldValue}',CHECK_DATE = getdate(), CHECK_USER='{_userGuid}' WHERE GUID='{_guid}'";
- int rows = DbHelperSQL.ExecuteSql(sql);
+ var sql =
+ $"UPDATE Mes_DepartmentToLine SET CHECK_STATUS='{_inFieldValue}',CHECK_DATE = getdate(), CHECK_USER='{_userGuid}' WHERE GUID='{_guid}'";
+ var rows = DbHelperSQL.ExecuteSql(sql);
m.outSum = rows;
m.outMsg = rows > 0 ? "鎿嶄綔鎴愬姛锛�" : "鏈洿鏂颁换浣曟暟鎹�";
}
@@ -150,8 +158,10 @@
LogHelper.Debug(ToString(), "EditModelSubmit error锛�" + ex.Message);
m.outMsg = ex.Message;
m.outSum = -1;
- return ReturnDto<dynamic>.QuickReturn(m, ReturnCode.Default, ex.Message);
+ return ReturnDto<dynamic>.QuickReturn(m, ReturnCode.Default,
+ ex.Message);
}
+
return ReturnDto<dynamic>.QuickReturn(m, ReturnCode.Success, "鎿嶄綔鎴愬姛锛�");
}
@@ -180,15 +190,18 @@
string sql;
if (CheckGuid(guid))
{
- sql = $"UPDATE Mes_DepartmentToLine SET DepartmentId='{departmentId}', DepartmentName='{departmentName}', Line_No='{lineNo}', Line_Name='{lineName}',OrgId = '{orgId}' WHERE GUID='{guid}'";
+ sql =
+ $"UPDATE Mes_DepartmentToLine SET DepartmentId='{departmentId}', DepartmentName='{departmentName}', Line_No='{lineNo}', Line_Name='{lineName}',OrgId = '{orgId}' WHERE GUID='{guid}'";
}
else
{
guid = Guid.NewGuid();
- sql = $" declare @userBy nvarchar(20); select top 1 @userBy=[ACCOUNT] from [dbo].[SYS_USER] where guid='{_userGuid}' " +
+ sql =
+ $" declare @userBy nvarchar(20); select top 1 @userBy=[ACCOUNT] from [dbo].[SYS_USER] where guid='{_userGuid}' " +
$"INSERT INTO Mes_DepartmentToLine (GUID, CREATE_BY, CREATE_DATE, DepartmentId, DepartmentName, Line_No, Line_Name,OrgId, CHECK_STATUS) VALUES ('{guid}',@userBy,GETDATE(), '{departmentId}', '{departmentName}', '{lineNo}', '{lineName}','{orgId}', 0)";
}
- int rows = DbHelperSQL.ExecuteSql(sql);
+
+ var rows = DbHelperSQL.ExecuteSql(sql);
mObj.outSum = rows;
mObj.outGuid = guid.ToString();
mObj.outMsg = rows > 0 ? "鎿嶄綔鎴愬姛锛�" : "鏈洿鏂颁换浣曟暟鎹�";
@@ -199,9 +212,12 @@
mObj.outMsg = ex.Message;
mObj.outSum = -1;
}
+
if (mObj.outSum <= 0)
- return ReturnDto<dynamic>.QuickReturn(mObj, ReturnCode.Exception, mObj.outMsg);
- return ReturnDto<dynamic>.QuickReturn(mObj, ReturnCode.Success, mObj.outMsg);
+ return ReturnDto<dynamic>.QuickReturn(mObj, ReturnCode.Exception,
+ mObj.outMsg);
+ return ReturnDto<dynamic>.QuickReturn(mObj, ReturnCode.Success,
+ mObj.outMsg);
}
/// <summary>
@@ -220,7 +236,8 @@
{
if (CheckGuid(guid))
{
- string sql = $"DELETE FROM Mes_DepartmentToLine WHERE GUID='{guid}'";
+ var sql =
+ $"DELETE FROM Mes_DepartmentToLine WHERE GUID='{guid}'";
_outSum = DbHelperSQL.ExecuteSql(sql);
_outMsg = _outSum > 0 ? "鍒犻櫎鎴愬姛锛�" : "鏈垹闄や换浣曟暟鎹�";
}
@@ -236,8 +253,10 @@
_outMsg = ex.Message;
_outSum = -1;
}
+
if (_outSum <= 0)
- return ReturnDto<int>.QuickReturn(rtnInt, ReturnCode.Exception, _outMsg);
+ return ReturnDto<int>.QuickReturn(rtnInt, ReturnCode.Exception,
+ _outMsg);
return ReturnDto<int>.QuickReturn(rtnInt, ReturnCode.Success, _outMsg);
}
@@ -252,9 +271,10 @@
dynamic m = new ExpandoObject();
try
{
- string sql = "SELECT id AS 閮ㄩ棬Id, name AS 閮ㄩ棬鍚嶇О FROM OA_Department";
+ var sql = "SELECT id AS 閮ㄩ棬Id, name AS 閮ㄩ棬鍚嶇О FROM OA_Department";
var ds = DbHelperSQL.Query(sql);
- if (ds != null && ds.Tables.Count > 0 && ds.Tables[0].Rows.Count > 0)
+ if (ds != null && ds.Tables.Count > 0 &&
+ ds.Tables[0].Rows.Count > 0)
{
var list = ds.Tables[0].TableToDynamicList();
m.list = list;
@@ -269,6 +289,7 @@
LogHelper.Debug(ToString(), ex.Message);
m.list = new List<dynamic>();
}
+
return ReturnDto<dynamic>.QuickReturn(m, ReturnCode.Success, "璇诲彇鎴愬姛锛�");
}
@@ -283,9 +304,11 @@
dynamic m = new ExpandoObject();
try
{
- string sql = "SELECT line_no AS 浜х嚎缂栧彿, name AS 浜х嚎鍚嶇О FROM MES_WORKSHOP_LINE";
+ var sql =
+ "SELECT line_no AS 浜х嚎缂栧彿, name AS 浜х嚎鍚嶇О FROM MES_WORKSHOP_LINE";
var ds = DbHelperSQL.Query(sql);
- if (ds != null && ds.Tables.Count > 0 && ds.Tables[0].Rows.Count > 0)
+ if (ds != null && ds.Tables.Count > 0 &&
+ ds.Tables[0].Rows.Count > 0)
{
var list = ds.Tables[0].TableToDynamicList();
m.list = list;
@@ -300,7 +323,7 @@
LogHelper.Debug(ToString(), ex.Message);
m.list = new List<dynamic>();
}
+
return ReturnDto<dynamic>.QuickReturn(m, ReturnCode.Success, "璇诲彇鎴愬姛锛�");
}
-
}
\ No newline at end of file
--
Gitblit v1.9.3